Skip to content

bpo-40773: Fix rendering for 'retval' on the pdb page #21081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2020
Merged

bpo-40773: Fix rendering for 'retval' on the pdb page #21081

merged 1 commit into from
Jun 24, 2020

Conversation

arisaka97
Copy link
Contributor

@arisaka97 arisaka97 commented Jun 23, 2020 •
edited by miss-islington
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 23, 2020
@remilapeyre
Copy link
Contributor

Hi @arisaka97, it looks like you are having issues with GitHub PRs, is something wrong?

@arisaka97
Copy link
Contributor Author

I am sorry that I confused the title of PR with the content of commit. When I found that the commit could not be modified, I deleted the previous PR.

@arisaka97
Copy link
Contributor Author

I am very sorry for the inconvenience.

@remilapeyre
Copy link
Contributor

I am very sorry for the inconvenience.

It's not an issue at all, I just wanted to let you know that when merging, all the commits will get squashed and the code developer will have the possibility to change the commit message then. So it's not really an issue if you made a typo or an error :)

@arisaka97
Copy link
Contributor Author

I am very sorry for the inconvenience.

It's not an issue at all, I just wanted to let you know that when merging, all the commits will get squashed and the code developer will have the possibility to change the commit message then. So it's not really an issue if you made a typo or an error :)

Thank you for your patience :)

@miss-islington miss-islington merged commit cf18c9e into python:master Jun 24, 2020
@miss-islington
Copy link
Contributor

Thanks @arisaka97 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2020
@arisaka97 @miss-islington
bpo-40773: Fix rendering for 'retval' on the pdb page (pythonGH-21081)
ded3f07 
Automerge-Triggered-By: @merwok
(cherry picked from commit cf18c9e)

Co-authored-by: Arisaka97 <solitaire2312@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 24, 2020
@bedevere-bot
Copy link

GH-21128 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

GH-21129 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2020
@arisaka97 @miss-islington
bpo-40773: Fix rendering for 'retval' on the pdb page (pythonGH-21081)
9008b00 
Automerge-Triggered-By: @merwok
(cherry picked from commit cf18c9e)

Co-authored-by: Arisaka97 <solitaire2312@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2020
@arisaka97 @miss-islington
bpo-40773: Fix rendering for 'retval' on the pdb page (pythonGH-21081)
6b945d6 
Automerge-Triggered-By: @merwok
(cherry picked from commit cf18c9e)

Co-authored-by: Arisaka97 <solitaire2312@gmail.com>
@bedevere-bot
Copy link

GH-21130 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jun 24, 2020
@miss-islington @arisaka97
bpo-40773: Fix rendering for 'retval' on the pdb page (GH-21081)
c1634ac 
Automerge-Triggered-By: @merwok
(cherry picked from commit cf18c9e)

Co-authored-by: Arisaka97 <solitaire2312@gmail.com>
miss-islington added a commit that referenced this pull request Jun 24, 2020
@miss-islington @arisaka97
bpo-40773: Fix rendering for 'retval' on the pdb page (GH-21081)
ec05a7f 
Automerge-Triggered-By: @merwok
(cherry picked from commit cf18c9e)

Co-authored-by: Arisaka97 <solitaire2312@gmail.com>
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@arisaka97 @fasihahmad
bpo-40773: Fix rendering for 'retval' on the pdb page (pythonGH-21081)
3ca5738 
Automerge-Triggered-By: @merwok
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@arisaka97 @arun-mani-j
bpo-40773: Fix rendering for 'retval' on the pdb page (pythonGH-21081)
4bdd1af 
Automerge-Triggered-By: @merwok
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok merwok approved these changes

@remilapeyre remilapeyre remilapeyre approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arisaka97 @remilapeyre @miss-islington @bedevere-bot @merwok @the-knights-who-say-ni