Skip to content

bpo-41197: Async magic methods in contextlib.closing #21285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

bpo-41197: Async magic methods in contextlib.closing #21285

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9905b54
enh: handle asynchronous case for contextlib.closing
uburuntu Jul 1, 2020
b826fed
new: add test for async `closing` (1)
uburuntu Jul 2, 2020
9351f92
new: add test for async `closing` (2)
uburuntu Jul 2, 2020
72987db
enh: add async ctx manager base class
uburuntu Jul 2, 2020
0386c5a
new: add blurb news
uburuntu Jul 2, 2020
fb3bd5b
fix: use double backquotes around __aenter__ and __aexit__
uburuntu Aug 11, 2020
ae1b887
ref: limit line to 79 chars
uburuntu Aug 11, 2020
632a3eb
enh: change close to aclose for async case
uburuntu Aug 11, 2020
c0f1b62
ref: add blank lines between methods
uburuntu Aug 11, 2020
26c4250
Merge branch 'main' into master
uburuntu Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ref: add blank lines between methods
  • Loading branch information
@uburuntu
uburuntu committed Aug 11, 2020
commit c0f1b6238a5aff8fda95d86dcfe3ea8afa866fd6
4 changes: 4 additions & 0 deletions Lib/contextlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,12 +309,16 @@ class closing(AbstractContextManager, AbstractAsyncContextManager):
"""
def __init__(self, thing):
self.thing = thing

def __enter__(self):
return self.thing

def __exit__(self, *exc_info):
self.thing.close()

async def __aenter__(self):
return self.thing

async def __aexit__(self, *exc_info):
await self.thing.aclose()

Expand Down