Skip to content

bpo-37363: Add audit events to the http.client module #21321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2021
Merged

bpo-37363: Add audit events to the http.client module #21321

merged 4 commits into from
Apr 23, 2021
+41 −0

Conversation

gousaiyang
Copy link
Contributor

@gousaiyang gousaiyang commented Jul 4, 2020 •
edited by bedevere-bot
Loading

@matrixise
Copy link
Member

Hello @gousaiyang

Thank you for your contribution, really appreciated.

Could you add some tests, for example, you could check in Lib/tests/test_audit.py if you need some pointers.

@gousaiyang
Copy link
Contributor Author

Hi @matrixise. If you had time could you review this PR again? Thanks!

@matrixise matrixise self-assigned this Apr 22, 2021
@matrixise
Copy link
Member

Hi @gousaiyang

Your PR is on my list. I will check it asap.

Thank you

@matrixise matrixise merged commit 927b841 into python:master Apr 23, 2021
@matrixise
Copy link
Member

Just forgot to approve the branch, but everything seems fine to me.

@gousaiyang Thank you for your contribution, this one will be only in 3.10

@gousaiyang gousaiyang deleted the audit-http-client branch April 23, 2021 18:24
@zooba zooba mentioned this pull request Nov 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matrixise matrixise

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gousaiyang @matrixise @the-knights-who-say-ni @bedevere-bot