Skip to content

[3.6] bpo-39603: Prevent header injection in http methods (GH-18485) #21539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2020
Merged

[3.6] bpo-39603: Prevent header injection in http methods (GH-18485) #21539

merged 1 commit into from
Jul 19, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 18, 2020 •
edited by bedevere-bot
Loading

reject control chars in http method in http.client.putrequest to prevent http header injection
(cherry picked from commit 8ca8a2e)

Co-authored-by: AMIR 31338382+amiremohamadi@users.noreply.github.com

https://bugs.python.org/issue39603

@amiremohamadi @miss-islington
bpo-39603: Prevent header injection in http methods (pythonGH-18485)
ea33946 
reject control chars in http method in http.client.putrequest to prevent http header injection
(cherry picked from commit 8ca8a2e)

Co-authored-by: AMIR <31338382+amiremohamadi@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this pull request Jul 18, 2020
Merged
@gvanrossum
Copy link
Member

@ned-deily This is a header injection fix, seems useful to merge.

@miss-islington
Copy link
Contributor Author

@amiremohamadi: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

@miss-islington
Copy link
Contributor Author

@amiremohamadi: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

@ned-deily ned-deily merged commit f02de96 into python:3.6 Jul 19, 2020
@miss-islington miss-islington deleted the backport-8ca8a2e-3.6 branch July 19, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miss-islington @gvanrossum @ned-deily @the-knights-who-say-ni @bedevere-bot @amiremohamadi