Validate the AST produced by the parser in debug mode #21643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysnikolaou
approved these changes
Jul 27, 2020
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Sorry, @pablogsal, I could not cleanly backport this to |
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Jul 27, 2020
…-21643) This will improve the debug experience if something fails in the produced AST. Previously, errors in the produced AST can be felt much later like in the garbage collector or the compiler, making debugging them much more difficult.. (cherry picked from commit 1332226) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
|
GH-21646 is a backport of this pull request to the 3.9 branch. |
pablogsal
added a commit
that referenced
this pull request
Jul 27, 2020
GH-21646) This will improve the debug experience if something fails in the produced AST. Previously, errors in the produced AST can be felt much later like in the garbage collector or the compiler, making debugging them much more difficult.. (cherry picked from commit 1332226) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 4, 2020
This will improve the debug experience if something fails in the produced AST. Previously, errors in the produced AST can be felt much later like in the garbage collector or the compiler, making debugging them much more difficult.
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 20, 2020
This will improve the debug experience if something fails in the produced AST. Previously, errors in the produced AST can be felt much later like in the garbage collector or the compiler, making debugging them much more difficult.
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
This will improve the debug experience if something fails in the produced AST. Previously, errors in the produced AST can be felt much later like in the garbage collector or the compiler, making debugging them much more difficult.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will improve the debug experience if something fails in the produced AST. Previously, errors in the produced AST can be felt much later like in the garbage collector or the compiler, making debugging them much more difficult.