Skip to content

Conversation

jaybosamiya
Copy link

See https://bugs.python.org/issue30657 for the issue and POC for overflow.

Checks and prevents possible integer overflow in PyString_DecodeEscape
@serhiy-storchaka
Copy link
Member

Please add also an entry in Misc/NEWS (with "Patch by Jay Bosamiya.") and your name in Misc/ACKS.

@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Jun 18, 2017
@serhiy-storchaka serhiy-storchaka merged commit c3c9db8 into python:2.7 Jun 18, 2017
@serhiy-storchaka
Copy link
Member

Thank you for your contribution Jay! Seems this is your first contribution to CPython, and I hope not the last.

@jaybosamiya
Copy link
Author

jaybosamiya commented Jun 18, 2017

Thanks for the very quick response time for each stage, Serhiy (from reviewing the initial issue report to reviewing the patch and merging) :) It made it nice and easy for contributing.

Yep, it is my first contribution to CPython, and I too hope it is not my last :)

@praveenjosh
Copy link

Hi i am very new to python. I want to install the patch to my local python 2.7 version.Can you let me know how can i do that ? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants