-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-41521: Replace whitelist/blacklist with allowlist/denylist #21824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change is backward incompatible, but test.support doesn't provide any backward compatibility warranty: "The test package is meant for internal use by Python only." At least, I wrote a NEWS entry to document the change. |
Is |
I agree with Serhiy about |
They are not necessary private. They are just not imported by star-import. For example |
Fair point. So then |
Well, nobody said that "blacklist" was a best term in the first place :-D @serhiy-storchaka, @vsajip: What do you think of |
IMO |
Rename "blacklist" parameter of test.support.check__all__() to "not_exported".
@vsajip: Ok, I modified my PR to use not_exported name instead. It's a better name than "blacklist". |
@serhiy-storchaka @vsajip: Would you mind to review the updated PR? |
@vsajip @serhiy-storchaka: Thank you for your reviews, "not_exported" is a better name than "denylist" (or "blacklist") ;-) |
Rename "blacklist" parameter of test.support.check__all__() to "not_exported".
Rename "blacklist" parameter of test.support.check__all__() to "not_exported".
Rename "blacklist" parameter of test.support.check__all__() to
"denylist".
https://bugs.python.org/issue41521