Skip to content

bpo-41533: Fix a potential memory leak when allocating a stack #21847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2020

Conversation

tontinton
Copy link
Contributor

@tontinton tontinton commented Aug 12, 2020

Free the stack allocated in va_build_stack if do_mkstack fails
and the stack is not a small_stack

https://bugs.python.org/issue41533

Free the stack allocated in va_build_stack if do_mkstack fails
and the stack is not a small_stack
@miss-islington
Copy link
Contributor

Thanks @tontinton for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 30, 2020
…pythonGH-21847)

Free the stack allocated in va_build_stack if do_mkstack fails
and the stack is not a small_stack
(cherry picked from commit 75c80b0)

Co-authored-by: Tony Solomonik <tony.solomonik@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 30, 2020
@bedevere-bot
Copy link

GH-22014 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 30, 2020
…pythonGH-21847)

Free the stack allocated in va_build_stack if do_mkstack fails
and the stack is not a small_stack
(cherry picked from commit 75c80b0)

Co-authored-by: Tony Solomonik <tony.solomonik@gmail.com>
@bedevere-bot
Copy link

GH-22015 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 4, 2020
… stack (GH-21847) (GH-22015)

Free the stack allocated in va_build_stack if do_mkstack fails
and the stack is not a small_stack
(cherry picked from commit 75c80b0)


Co-authored-by: Tony Solomonik <tony.solomonik@gmail.com>
@Mariatta Mariatta added the needs backport to 3.9 only security fixes label Sep 4, 2020
@miss-islington
Copy link
Contributor

Thanks @tontinton for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2020
…pythonGH-21847)

Free the stack allocated in va_build_stack if do_mkstack fails
and the stack is not a small_stack
(cherry picked from commit 75c80b0)

Co-authored-by: Tony Solomonik <tony.solomonik@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Sep 4, 2020
@bedevere-bot
Copy link

GH-22103 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Sep 4, 2020
…GH-21847)

Free the stack allocated in va_build_stack if do_mkstack fails
and the stack is not a small_stack
(cherry picked from commit 75c80b0)

Co-authored-by: Tony Solomonik <tony.solomonik@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
…pythonGH-21847)

Free the stack allocated in va_build_stack if do_mkstack fails
and the stack is not a small_stack
@tongxiaoge1001
Copy link

Is python3.7 involved? I find that the python3.7 branch is not incorporated, but do_mkstack also could fail in python3.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants