-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-40994: Ungroup items in collections.abc documentation for improved clarity #21880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
I think the title should be, instead of "Clarify documentation using 'respectively' construct", something that says more clearly where the change was made. Something like "Ungroup items in collections.abc documentation for improved clarity". |
@iritkatriel Thank you so much for the prompt review. I was tangling with the first time setup of a Python PR and I made some pretty bonehead errors there. I've addressed your feedback and am working on straightening out the CLA. I know I signed it but it's not getting associated with my account somehow. |
Thank you for addressing the comments. I think the CLA can take a day or two. In the meantime, it would be tidier to squash the two commits into one, so that the commit log is clean. |
Excellent. I will rebase them. |
89ead02
to
bd4229f
Compare
I have my Github username configured as Edit: I now get a 500 on https://check-python-cla.herokuapp.com/ with |
bd4229f
to
b2b1150
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I like this improve, LGTM
@sydneypemberton1986, looking at the user screen on bugs.python.org, I believe you need to remove the '@' at the beginning of the Github name for the bot to be able to match to it. Thanks! |
Sorry, I can't merge this PR. Reason: |
I'm going to close and reopen this to retrigger Travis CI. |
@sydneypemberton1986: Status check is done, and it's a success ✅ . |
1 similar comment
@sydneypemberton1986: Status check is done, and it's a success ✅ . |
Sorry, I can't merge this PR. Reason: |
1 similar comment
Sorry, I can't merge this PR. Reason: |
@sydneypemberton1986: Status check is done, and it's a success ✅ . |
Thanks @sydneypemberton1986 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
…d clarity (pythonGH-21880) Use a less surprising document structure. Automerge-Triggered-By: @csabella (cherry picked from commit 2ce3963) Co-authored-by: Sydney Pemberton <46042811+sydneypemberton1986@users.noreply.github.com>
GH-21926 is a backport of this pull request to the 3.9 branch. |
…d clarity (pythonGH-21880) Use a less surprising document structure. Automerge-Triggered-By: @csabella (cherry picked from commit 2ce3963) Co-authored-by: Sydney Pemberton <46042811+sydneypemberton1986@users.noreply.github.com>
GH-21927 is a backport of this pull request to the 3.8 branch. |
@sydneypemberton1986 thank you for the contribution and welcome to CPython! 🎉 🎉 🎉 @iritkatriel, @eamanu, and @rhettinger, thank you for the reviews! |
…d clarity (pythonGH-21880) Use a less surprising document structure. Automerge-Triggered-By: @csabella
Use a less surprising document structure.
https://bugs.python.org/issue40994
Automerge-Triggered-By: @csabella