Skip to content

bpo-41572: Documentation wording fix #21914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2020
Merged

bpo-41572: Documentation wording fix #21914

merged 1 commit into from
Aug 20, 2020

Conversation

clebergnu
Copy link
Contributor

@clebergnu clebergnu commented Aug 18, 2020 •
edited by bedevere-bot
Loading

The docstring on asyncio.transports.BaseTransport.close() is missing a
verb.

https://bugs.python.org/issue41572

Signed-off-by: Cleber Rosa crosa@redhat.com

https://bugs.python.org/issue41572

@clebergnu
Documentation wording fix
b0cdb85 
The docstring on asyncio.transports.BaseTransport.close() is missing a
verb.

https://bugs.python.org/issue41572

Signed-off-by: Cleber Rosa <crosa@redhat.com>
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@clebergnu

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@tirkarthi
Copy link
Member

@clebergnu Nothing else. It needs to be reviewed and approved. The change looks fine to me.

@tirkarthi
Copy link
Member

Closing and reopening PR for CI.

@tirkarthi tirkarthi closed this Aug 18, 2020
@tirkarthi tirkarthi reopened this Aug 18, 2020
tirkarthi
tirkarthi approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@tirkarthi tirkarthi merged commit 1afb42c into python:master Aug 20, 2020
@miss-islington
Copy link
Contributor

Thanks @clebergnu for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @clebergnu for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 20, 2020
@clebergnu @miss-islington
bpo-41572: Fix grammar in BaseTransport.close docstring (pythonGH-21914)
33244ff 
Fix grammar in BaseTransport.close docstring.

https://bugs.python.org/issue41572

Signed-off-by: Cleber Rosa <crosa@redhat.com>
(cherry picked from commit 1afb42c)

Co-authored-by: Cleber Rosa <cleber.gnu@gmail.com>
@bedevere-bot
Copy link

GH-21929 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 20, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 20, 2020
@clebergnu @miss-islington
bpo-41572: Fix grammar in BaseTransport.close docstring (pythonGH-21914)
d8ee1d2 
Fix grammar in BaseTransport.close docstring.

https://bugs.python.org/issue41572

Signed-off-by: Cleber Rosa <crosa@redhat.com>
(cherry picked from commit 1afb42c)

Co-authored-by: Cleber Rosa <cleber.gnu@gmail.com>
@bedevere-bot
Copy link

GH-21930 is a backport of this pull request to the 3.8 branch.

tirkarthi pushed a commit that referenced this pull request Aug 21, 2020
@miss-islington @clebergnu
bpo-41572: Fix grammar in BaseTransport.close docstring (GH-21914) (#…
a2d00f0 
…21929)

Fix grammar in BaseTransport.close docstring.

https://bugs.python.org/issue41572

Signed-off-by: Cleber Rosa <crosa@redhat.com>
(cherry picked from commit 1afb42c)

Co-authored-by: Cleber Rosa <cleber.gnu@gmail.com>
tirkarthi pushed a commit that referenced this pull request Aug 21, 2020
@miss-islington @clebergnu
bpo-41572: Fix grammar in BaseTransport.close docstring (GH-21914) (G…
1370d9d 
…H-21930)

Fix grammar in BaseTransport.close docstring.

https://bugs.python.org/issue41572

Signed-off-by: Cleber Rosa <crosa@redhat.com>
(cherry picked from commit 1afb42c)

Co-authored-by: Cleber Rosa <cleber.gnu@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@clebergnu
bpo-41572: Fix grammar in BaseTransport.close docstring (pythonGH-21914)
82502d0 
Fix grammar in BaseTransport.close docstring.

https://bugs.python.org/issue41572

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clebergnu @the-knights-who-say-ni @tirkarthi @miss-islington @bedevere-bot