Further improve accuracy of math.hypot() #22013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When summing the squares, the lossy step occurs during the accumulation of fractional values. We can improve accuracy by keeping a separate accumulator for the
frac += lo * lo
step so that the small fractional values don't get overpowered by the larger fractional values.As a nice side benefit, the generated code is slightly smaller — it saves two
movapd
instructions without increasing the number of registers in use.. Also the flow graph has fewer sequential dependencies to interfere with pipelining and parallel execution.I compared having one, two, or three separate fractional value accumulators. For all dimensions, two accumulators are more accurate than just one. Up to a dozen or so dimensions, two accumulators are more accurate than three. See the analysis code at https://bugs.python.org/file49435/best_frac.py
https://bugs.python.org/issue41513