Fixed bpo-29565: Corrected ctypes passing of large structs by value o… #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Windows AMD64. (#168) * Fixed bpo-29565: Corrected ctypes passing of large structs by value. Added code and test to check that when a structure passed by value is large enough to need to be passed by reference, a copy of the original structure is passed. The callee updates the passed-in value, and the test verifies that the caller's copy is unchanged. A similar change was also added to the test added for bpo-20160 (that test was passing, but the changes should guard against regressions). * Reverted unintended whitespace changes. (cherry picked from commit a86339b)
Codecov Report
@@ Coverage Diff @@
## 3.5 #221 +/- ##
======================================
Coverage ? 82.41%
======================================
Files ? 1404
Lines ? 341474
Branches ? 0
======================================
Hits ? 281440
Misses ? 60034
Partials ? 0
Continue to review full report at Codecov.
|
zooba
approved these changes
Feb 21, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jul 1, 2019
These numbers were already 64bit if available until the relevant preprocessor macro was renamed. This change affects Stackless structures PyStacklessState and PyCStackObject. Extension authors usually don't access them directly.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
May 27, 2021
These numbers were already 64bit if available until the relevant preprocessor macro was renamed. This change affects Stackless structures PyStacklessState and PyCStackObject. Extension authors usually don't access them directly. (cherry picked from commit ce8faba)
jaraco
added a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
Replace legacy API implementation with files()
jaraco
added a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n Windows AMD64. (#168)
Closed bpo-29565: Corrected ctypes passing of large structs by value.
(cherry picked from commit a86339b)