Skip to content

bpo-41792 / typing#751 - Add is_typeddict function to typing.py #22254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 16, 2020
Merged

bpo-41792 / typing#751 - Add is_typeddict function to typing.py #22254

merged 4 commits into from
Sep 16, 2020

Conversation

pxeger
Copy link
Contributor

@pxeger pxeger commented Sep 15, 2020 •
edited by bedevere-bot
Loading

@pxeger pxeger changed the title typing typing#751 - Add is_typeddict function to typing.py Sep 15, 2020
@pxeger pxeger changed the title typing#751 - Add is_typeddict function to typing.py bpo-41792 / typing#751 - Add is_typeddict function to typing.py Sep 15, 2020
@gvanrossum
Copy link
Member

gvanrossum commented Sep 16, 2020 •
edited
Loading

The Windows asyncio test failure must be a flake. Let’s merge. Thanks!

@gvanrossum gvanrossum merged commit 0705ec8 into python:master Sep 16, 2020
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 LTO + PGO 3.x has failed when building commit 0705ec8.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/458/builds/493) and take a look at the build logs.
  4. Check if the failure is related to this commit (0705ec8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/458/builds/493

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

408 tests OK.

10 slowest tests:

  • test_peg_generator: 6 min 51 sec
  • test_concurrent_futures: 3 min 1 sec
  • test_tokenize: 1 min 23 sec
  • test_multiprocessing_spawn: 1 min 22 sec
  • test_asyncio: 1 min 7 sec
  • test_multiprocessing_forkserver: 1 min 4 sec
  • test_unparse: 1 min
  • test_multiprocessing_fork: 55.5 sec
  • test_lib2to3: 50.3 sec
  • test_signal: 47.4 sec

1 test altered the execution environment:
test_asyncio

14 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 7 min 48 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/asyncio/sslproto.py", line 321, in __del__
    self.close()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/asyncio/sslproto.py", line 316, in close
    self._ssl_protocol._start_shutdown()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
    self._abort()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/asyncio/sslproto.py", line 731, in _abort
    self._transport.abort()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/asyncio/selector_events.py", line 680, in abort
    self._force_close(None)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/asyncio/selector_events.py", line 731, in _force_close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/asyncio/base_events.py", line 746, in call_soon
    self._check_closed()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/asyncio/base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@pxeger
bpo-41792: Add is_typeddict function to typing.py (pythonGH-22254)
29ef8f2 
Closes issue41792.

Also closes python/typing#751.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pxeger @gvanrossum @bedevere-bot @the-knights-who-say-ni