Fix import of HTTPError #22304
Merged
Fix import of HTTPError #22304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import HTTPError from urllib.error instead of urllib.request.
18 tasks
orsenthil
approved these changes
May 11, 2021
|
Thanks @srittau for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 11, 2021
Import HTTPError from urllib.error instead of urllib.request. (cherry picked from commit 5fedf71) Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
|
GH-26047 is a backport of this pull request to the 3.10 branch. |
|
GH-26048 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 11, 2021
Import HTTPError from urllib.error instead of urllib.request. (cherry picked from commit 5fedf71) Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
orsenthil
pushed a commit
that referenced
this pull request
May 11, 2021
orsenthil
pushed a commit
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import HTTPError from urllib.error instead of urllib.request.
This issue was flagged by python/typeshed#2149. It is a minor issue, but helps in the effort to check the standard lib with mypy.