Skip to content

bpo-41513: Second attempt to add accuracy tests for math.hypot() #22327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 21, 2020

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Sep 19, 2020

Formerly, these tests succeeded on all buildbots except the Gentoo AMD Athlon build.

Am attempting to get it to pass by adding the same guards used in testFsum(). This requires IEEE-754 and will skip the test in double rounding environments.

If this still fails, will revert and abandon the effort to add accuracy tests.

https://bugs.python.org/issue41513

@rhettinger
Copy link
Contributor Author

After 9 hours, the Travis CI seems to be wedged. Perhaps closing and reopening will trigger a new build.

@rhettinger rhettinger closed this Sep 20, 2020
@rhettinger rhettinger reopened this Sep 20, 2020
@vstinner
Copy link
Member

If you want to test Gentoo, you can add the buildbot label.

@rhettinger rhettinger added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 20, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 5edc606 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 20, 2020
@rhettinger rhettinger requested a review from tim-one September 20, 2020 21:42
@rhettinger rhettinger added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 20, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 9255115 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 20, 2020
@rhettinger rhettinger added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 21, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 6da426d 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 21, 2020
@rhettinger rhettinger added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 21, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 1cd8b13 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 21, 2020
@rhettinger rhettinger merged commit bc6b7fa into python:master Sep 21, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants