Skip to content

bpo-1635741: Port _bisect module to multi-phase init #22415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 26, 2020
Merged

bpo-1635741: Port _bisect module to multi-phase init #22415

merged 5 commits into from
Sep 26, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Sep 26, 2020 •
edited by bedevere-bot
Loading

@corona10
Copy link
Member Author

@shihai1991 Can you please take a look?

@corona10 corona10 requested a review from vstinner September 26, 2020 08:37
shihai1991
shihai1991 approved these changes Sep 26, 2020
View reviewed changes
Copy link
Member

@shihai1991 shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@corona10 corona10 requested a review from vstinner September 26, 2020 10:32
vstinner
vstinner approved these changes Sep 26, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This conversion was easy :-D

I checked manually: the module and the module functions are stateless, there is no other change needed.

@corona10 corona10 merged commit 2afd175 into python:master Sep 26, 2020
@corona10 corona10 deleted the bpo-1635741-bisect branch September 26, 2020 10:56
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@shihai1991 shihai1991 shihai1991 approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @vstinner @shihai1991 @the-knights-who-say-ni @bedevere-bot