Skip to content

bpo-41867: Include options for timespec in docstrings of isoformat methods #22418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2020
Merged

bpo-41867: Include options for timespec in docstrings of isoformat methods #22418

merged 3 commits into from
Oct 3, 2020

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Sep 26, 2020 •
edited by bedevere-bot
Loading

@taleinat
Copy link
Contributor

taleinat commented Oct 2, 2020 •
edited
Loading

Hi Ram, thanks for this, it's a nice addition!

What about the doc-strings for the C implementation? (e.g. here)

@taleinat taleinat added skip news docs Documentation in the Doc dir labels Oct 2, 2020
@taleinat
Copy link
Contributor

taleinat commented Oct 2, 2020

What about the doc-strings for the C implementation? (e.g. here)

It seems that the C implementation for datetime.iso_format() already has something very similar in its doc-string, while time.iso_format() doesn't.

Let's make these all consistent.

@cool-RR cool-RR force-pushed the 2020-09-26-isoformat branch 2 times, most recently from e2e0ba5 to 8a7abe4 Compare October 3, 2020 09:34
@cool-RR
Copy link
Contributor Author

cool-RR commented Oct 3, 2020

Done.

taleinat
taleinat requested changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go, just a couple of small comments.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@cool-RR cool-RR force-pushed the 2020-09-26-isoformat branch from 8a7abe4 to 70dd716 Compare October 3, 2020 09:46
@cool-RR
Copy link
Contributor Author

cool-RR commented Oct 3, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from taleinat October 3, 2020 09:46
taleinat
taleinat requested changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, @cool-RR, that was quick!

One more thing...

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@cool-RR cool-RR force-pushed the 2020-09-26-isoformat branch from 70dd716 to dbfeb83 Compare October 3, 2020 09:53
@cool-RR
Copy link
Contributor Author

cool-RR commented Oct 3, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

@cool-RR cool-RR force-pushed the 2020-09-26-isoformat branch from dbfeb83 to 2cf017b Compare October 3, 2020 09:58
@cool-RR
Copy link
Contributor Author

cool-RR commented Oct 3, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from taleinat October 3, 2020 09:59
taleinat
taleinat approved these changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taleinat taleinat merged commit 5230131 into python:master Oct 3, 2020
@miss-islington
Copy link
Contributor

Thanks @cool-RR for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2020
@cool-RR @miss-islington
bpo-41867: List options for timespec in docstrings of isoformat metho…
ff70df1 
…ds (pythonGH-22418)

(cherry picked from commit 5230131)

Co-authored-by: Ram Rachum <ram@rachum.com>
@bedevere-bot
Copy link

GH-22518 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 3, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2020
@cool-RR @miss-islington
bpo-41867: List options for timespec in docstrings of isoformat metho…
84ca5e5 
…ds (pythonGH-22418)

(cherry picked from commit 5230131)

Co-authored-by: Ram Rachum <ram@rachum.com>
@bedevere-bot
Copy link

GH-22519 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 3, 2020
@miss-islington @cool-RR
bpo-41867: List options for timespec in docstrings of isoformat metho…
9aa34f1 
…ds (GH-22418)

(cherry picked from commit 5230131)

Co-authored-by: Ram Rachum <ram@rachum.com>
taleinat pushed a commit that referenced this pull request Oct 3, 2020
@miss-islington @cool-RR
[3.9] bpo-41867: List options for timespec in docstrings of isoformat…
8ca0831 
… methods (GH-22418)

(cherry picked from commit 5230131)

Co-authored-by: Ram Rachum <ram@rachum.com>
ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020
@miss-islington @cool-RR @ambv
[3.9] bpo-41867: List options for timespec in docstrings of isoformat…
faaa303 
… methods (pythonGH-22418)

(cherry picked from commit 5230131)

Co-authored-by: Ram Rachum <ram@rachum.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@cool-RR
bpo-41867: List options for timespec in docstrings of isoformat metho…
b85c4f4 
…ds (pythonGH-22418)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat taleinat approved these changes

@abalkin abalkin Awaiting requested review from abalkin

@pganssle pganssle Awaiting requested review from pganssle

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cool-RR @taleinat @bedevere-bot @miss-islington @the-knights-who-say-ni