Skip to content

bpo-41889: enum: fix multiple-inheritance regression #22487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Lib/enum.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,9 @@ def __new__(metacls, cls, bases, classdict):
for key in ignore:
classdict.pop(key, None)
member_type, first_enum = metacls._get_mixins_(cls, bases)
__new__, save_new, use_args = metacls._find_new_(classdict, member_type,
first_enum)
__new__, save_new, use_args = metacls._find_new_(
classdict, member_type, first_enum,
)

# save enum items into separate mapping so they don't get baked into
# the new class
Expand Down Expand Up @@ -501,12 +502,16 @@ def _find_data_type(bases):
for base in chain.__mro__:
if base is object:
continue
elif issubclass(base, Enum):
if base._member_type_ is not object:
data_types.append(base._member_type_)
break
elif '__new__' in base.__dict__:
if issubclass(base, Enum):
continue
data_types.append(candidate or base)
break
elif not issubclass(base, Enum):
else:
candidate = base
if len(data_types) > 1:
raise TypeError('%r: too many data types: %r' % (class_name, data_types))
Expand Down
26 changes: 26 additions & 0 deletions Lib/test/test_enum.py
Original file line number Diff line number Diff line change
Expand Up @@ -2021,6 +2021,32 @@ class Decision2(MyEnum):
REVERT_ALL = "REVERT_ALL"
RETRY = "RETRY"

def test_multiple_mixin_inherited(self):
class MyInt(int):
def __new__(cls, value):
return super().__new__(cls, value)

class HexMixin:
def __repr__(self):
return hex(self)

class MyIntEnum(HexMixin, MyInt, enum.Enum):
pass

class Foo(MyIntEnum):
TEST = 1
self.assertTrue(isinstance(Foo.TEST, MyInt))
self.assertEqual(repr(Foo.TEST), "0x1")

class Fee(MyIntEnum):
TEST = 1
def __new__(cls, value):
value += 1
member = int.__new__(cls, value)
member._value_ = value
return member
self.assertEqual(Fee.TEST, 2)

def test_empty_globals(self):
# bpo-35717: sys._getframe(2).f_globals['__name__'] fails with KeyError
# when using compile and exec because f_globals is empty
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Enum: fix regression involving inheriting a multiply-inherited enum