Skip to content

bpo-41898: add caveat on root logger seeing all messages #22526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Oct 3, 2020

@iritkatriel
Copy link
Member Author

iritkatriel commented Oct 3, 2020

@vsajip, @pitrou do you agree?

@pitrou
Copy link
Member

pitrou commented Oct 4, 2020

That looks good to me.

@vsajip vsajip merged commit 1ed5443 into python:master Oct 4, 2020
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @iritkatriel and @vsajip, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 1ed54435268b285964141fb74d47ceaa33ea79ab 3.9

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2020
…s doc (pythonGH-22526)

(cherry picked from commit 1ed5443)

Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
@bedevere-bot
Copy link

GH-22537 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-22538 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2020
…s doc (pythonGH-22526)

(cherry picked from commit 1ed5443)

Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
vsajip pushed a commit that referenced this pull request Oct 4, 2020
@vsajip vsajip added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Oct 4, 2020
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2020
…s doc (pythonGH-22526)

(cherry picked from commit 1ed5443)

Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 4, 2020
@bedevere-bot
Copy link

GH-22540 is a backport of this pull request to the 3.9 branch.

vsajip pushed a commit that referenced this pull request Oct 4, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@iritkatriel iritkatriel deleted the assertLogsDoc branch November 27, 2020 15:19
@iritkatriel iritkatriel restored the assertLogsDoc branch November 27, 2020 15:19
@iritkatriel iritkatriel deleted the assertLogsDoc branch August 2, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants