Skip to content

Fix incorrect parameter name #22613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2020
Merged

Fix incorrect parameter name #22613

merged 1 commit into from
Oct 10, 2020

Conversation

xyb
Copy link
Contributor

@xyb xyb commented Oct 9, 2020 •
edited by miss-islington
Loading

Automerge-Triggered-By: @Mariatta

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@xyb

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 9, 2020
Mariatta
Mariatta approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@miss-islington miss-islington merged commit a427593 into python:master Oct 10, 2020
@miss-islington
Copy link
Contributor

Thanks @xyb for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @xyb, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a42759351bff7b07fa8bf2cece0088f8539721d1 3.9

@miss-islington miss-islington self-assigned this Oct 10, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2020
@xyb @miss-islington
Fix incorrect parameter name (pythonGH-22613)
8ec5189 
Automerge-Triggered-By: @Mariatta
(cherry picked from commit a427593)

Co-authored-by: Xie Yanbo <xieyanbo@gmail.com>
@bedevere-bot
Copy link

GH-22627 is a backport of this pull request to the 3.8 branch.

xyb added a commit to xyb/cpython that referenced this pull request Oct 10, 2020
@xyb
[3.9] Fix incorrect parameter name (pythonGH-22613)
803b665 
Automerge-Triggered-By: @Mariatta
(cherry picked from commit a427593)

Co-authored-by: Xie Yanbo <xieyanbo@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 10, 2020
@bedevere-bot
Copy link

GH-22628 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Oct 10, 2020
@miss-islington @xyb
Fix incorrect parameter name (GH-22613)
ae485f5 
Automerge-Triggered-By: @Mariatta
(cherry picked from commit a427593)

Co-authored-by: Xie Yanbo <xieyanbo@gmail.com>
tirkarthi pushed a commit that referenced this pull request Oct 15, 2020
@xyb
[3.9] Fix incorrect parameter name (GH-22613) (GH-22628)
b30934e 
Automerge-Triggered-By: @Mariatta
(cherry picked from commit a427593)

Co-authored-by: Xie Yanbo <xieyanbo@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@xyb
Fix incorrect parameter name (pythonGH-22613)
fac6798 
Automerge-Triggered-By: @Mariatta
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@xyb @adorilson
Fix incorrect parameter name (pythonGH-22613)
810b1cf 
Automerge-Triggered-By: @Mariatta
@xyb xyb deleted the patch-1 branch April 26, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

@eamanu eamanu eamanu approved these changes

Assignees

@miss-islington miss-islington

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xyb @the-knights-who-say-ni @miss-islington @bedevere-bot @Mariatta @eamanu