Skip to content

gh-86155: Fix htmlparser "unclosed script tag causes data loss" #22658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

gh-86155: Fix htmlparser "unclosed script tag causes data loss" #22658

wants to merge 6 commits into from
+13 −1

Conversation

waylan
Copy link

@waylan waylan commented Oct 12, 2020 •
edited by bedevere-bot
Loading

When calling .close() the htmlparser should flush all remaining content,
even when that content is in an unclosed script or style tag.

https://bugs.python.org/issue41989

@waylan
bpo:41989 Fix htmlparser "unclosed script tag causes data loss"
3c5c943 
When calling .close() the htmlparser should flush all remaining content,
even when that content is in an unclosed script or style tag.
@waylan waylan requested a review from ezio-melotti as a code owner October 12, 2020 01:12
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@waylan

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@waylan waylan changed the title bpo:41989 Fix htmlparser "unclosed script tag causes data loss" bpo-41989 Fix htmlparser "unclosed script tag causes data loss" Oct 12, 2020
@waylan waylan mentioned this pull request Oct 12, 2020
Closed
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 17, 2020
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 30, 2022
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@arhadthedev arhadthedev changed the title bpo-41989 Fix htmlparser "unclosed script tag causes data loss" gh-86155: Fix htmlparser "unclosed script tag causes data loss" Feb 13, 2023
@arhadthedev arhadthedev added the stdlib Python modules in the Lib dir label Feb 13, 2023
@arhadthedev
Copy link
Member

@ezio-melotti (as an html expert)

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 18, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees
No one assigned
Labels
awaiting review stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@waylan @the-knights-who-say-ni @bedevere-bot @arhadthedev @ezio-melotti @hauntsaninja