Skip to content

bpo-42062: Set HTTPResponse.url at init #22738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bpo-42062: Set HTTPResponse.url at init #22738

wants to merge 2 commits into from
+2 −0

Conversation

fbidu
Copy link
Contributor

@fbidu fbidu commented Oct 17, 2020 •
edited by bedevere-bot
Loading

Apparently, HTTPResponse.url is accessed but not set by __init__ nor
any other method. This PR initializes it through __init__

https://bugs.python.org/issue42062

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
MaxwellDupre
MaxwellDupre suggested changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out this branch and modified the end of the your test script to:
a= r1.geturl() print (a) a =r1.url print (a)
And the output was None and None. For either of these to be useful shouldn't they output something other than none?
Also, could you add test(s) to the test module please?

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 30, 2022
iritkatriel
iritkatriel requested changes Dec 7, 2022
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above, a PR like this requires a unittest to assert that the bug being fixed does not reappear (though it's not clear that there is a bug here).

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@fbidu fbidu mannequin mentioned this pull request Apr 10, 2022
Open
@warren-bank warren-bank mentioned this pull request Jan 24, 2025
Merged
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 18, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel requested changes

@MaxwellDupre MaxwellDupre MaxwellDupre requested changes

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fbidu @bedevere-bot @iritkatriel @MaxwellDupre @the-knights-who-say-ni @ezio-melotti @hauntsaninja