Skip to content

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Oct 24, 2020

Fixes #82704.

shutil.copytree() now applies the ignore_dangling_symlinks
argument recursively.

Co-Authored-By: Rob Nelson veaviticus@gmail.com

https://bugs.python.org/issue38523

shutil.copytree() now applies the *ignore_dangling_symlinks*
argument recursively.

Co-Authored-By: Rob Nelson <veaviticus@gmail.com>
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@iritkatriel iritkatriel added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes type-bug An unexpected behavior, bug, or error labels Dec 6, 2021
@ambv ambv removed the needs backport to 3.9 only security fixes label May 17, 2022
@ambv
Copy link
Contributor

ambv commented May 17, 2022

This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today.

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.11 only security fixes label May 20, 2022
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 30, 2022
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-99193 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 7, 2022
@bedevere-bot
Copy link

GH-99194 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 7, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2022
…nGH-22937)

(cherry picked from commit 5ff81da)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2022
…nGH-22937)

(cherry picked from commit 5ff81da)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Nov 7, 2022
)

(cherry picked from commit 5ff81da)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Nov 7, 2022
)

(cherry picked from commit 5ff81da)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Non-Debug 3.11 has failed when building commit 5f83209.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/976/builds/521) and take a look at the build logs.
  4. Check if the failure is related to this commit (5f83209) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/976/builds/521

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

415 tests OK.

10 slowest tests:

  • test_multiprocessing_spawn: 4 min 51 sec
  • test_largefile: 4 min 30 sec
  • test_multiprocessing_forkserver: 4 min 23 sec
  • test_unparse: 4 min 13 sec
  • test_tokenize: 4 min 1 sec
  • test_concurrent_futures: 3 min 46 sec
  • test_asyncio: 3 min 25 sec
  • test_lib2to3: 2 min 44 sec
  • test_pydoc: 2 min 37 sec
  • test_multiprocessing_fork: 2 min 14 sec

1 test altered the execution environment:
test_concurrent_futures

20 tests skipped:
test_dbm_gnu test_devpoll test_epoll test_idle test_ioctl
test_launcher test_msilib test_readline test_spwd test_startfile
test_tcl test_tix test_tk test_ttk_guionly test_ttk_textonly
test_turtle test_winconsoleio test_winreg test_winsound
test_zipfile64

Total duration: 22 min 23 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.11.koobs-freebsd-9e36.nondebug/build/Lib/test/test_concurrent_futures.py", line 100, in __del__
    self.event.set()
  File "/usr/home/buildbot/python/3.11.koobs-freebsd-9e36.nondebug/build/Lib/multiprocessing/managers.py", line 1093, in set
    return self._callmethod('set')
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/home/buildbot/python/3.11.koobs-freebsd-9e36.nondebug/build/Lib/multiprocessing/managers.py", line 818, in _callmethod
    self._connect()
  File "/usr/home/buildbot/python/3.11.koobs-freebsd-9e36.nondebug/build/Lib/multiprocessing/managers.py", line 805, in _connect
    conn = self._Client(self._token.address, authkey=self._authkey)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/home/buildbot/python/3.11.koobs-freebsd-9e36.nondebug/build/Lib/multiprocessing/connection.py", line 501, in Client
    c = SocketClient(address)
        ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/home/buildbot/python/3.11.koobs-freebsd-9e36.nondebug/build/Lib/multiprocessing/connection.py", line 629, in SocketClient
    s.connect(address)
FileNotFoundError: [Errno 2] No such file or directory
k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore_dangling_symlinks in shutil.copytree does not apply recursively
8 participants