Skip to content

bpo-42160: reduce overhead in tempfile #22997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 30, 2020
Merged

bpo-42160: reduce overhead in tempfile #22997

merged 9 commits into from
Oct 30, 2020

Conversation

Deric-W
Copy link
Contributor

@Deric-W Deric-W commented Oct 27, 2020 •
edited by bedevere-bot
Loading

  • replace pid check in _RandomNameSequence with os.register_at_fork
  • add variants property to allow replacing TMP_MAX with a calculated value
  • fix small typo in test_tempfile

https://bugs.python.org/issue42160

@Deric-W
bpo-42160: reduce overhead in tempfile
f10516b 
The _RandomSequence class in tempfile used to check the current pid every time its rng property was used.
This commit replaces this code with os.register_at_fork to reduce the overhead.
@Deric-W
Merge branch 'master' of github.com:python/cpython into tempfile-over…
9a77aee 
…head
methane
methane reviewed Oct 29, 2020
View reviewed changes
methane
methane reviewed Oct 29, 2020
View reviewed changes
methane
methane reviewed Oct 29, 2020
View reviewed changes
@methane methane merged commit 8e409ce into python:master Oct 30, 2020
@Deric-W Deric-W deleted the tempfile-overhead branch October 30, 2020 13:12
methane added a commit that referenced this pull request Oct 31, 2020
@methane
Revert "bpo-42160: tempfile: Reduce overhead of pid check. (GH-22997)"
9198cc5 
This reverts commit 8e409ce.
@methane methane mentioned this pull request Oct 31, 2020
Merged
methane added a commit that referenced this pull request Oct 31, 2020
@methane
Revert "bpo-42160: tempfile: Reduce overhead of pid check. (GH-22997)"
43ca084 
`_RandomNameSequence` is not true singleton so using `os.register_at_fork` doesn't make sense unlike `random._inst`.

This reverts commit 8e409ce.
@methane methane mentioned this pull request Nov 1, 2020
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@Deric-W @adorilson
bpo-42160: tempfile: Reduce overhead of pid check. (pythonGH-22997)
07b5ace 
The _RandomSequence class in tempfile used to check the current pid every time its rng property was used.
This commit replaces this code with `os.register_at_fork` to reduce the overhead.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@methane @adorilson
Revert "bpo-42160: tempfile: Reduce overhead of pid check. (pythonGH-…
efe9810 
…22997)"

`_RandomNameSequence` is not true singleton so using `os.register_at_fork` doesn't make sense unlike `random._inst`.

This reverts commit 8e409ce.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Deric-W @methane @the-knights-who-say-ni @bedevere-bot