Skip to content

bpo-42194: Add "New in version: 3.9" to argparse.BooleanOptionalAction #23026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2021
Merged

bpo-42194: Add "New in version: 3.9" to argparse.BooleanOptionalAction #23026

merged 1 commit into from
Jul 12, 2021

Conversation

shangxiao
Copy link
Contributor

@shangxiao shangxiao commented Oct 29, 2020 •
edited by bedevere-bot
Loading

Hi :)

Just noticed that docs for argparse.BooleanOptionalAction is missing the "New in version" label as it seems to be a recent addition in 3.9.0. I'm assuming this will require a backport to a 3.9.x branch?

Cheers!

https://bugs.python.org/issue42194

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@shangxiao

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 29, 2020
@ammaraskar
Copy link
Member

For other reviewer's reference, this was added as part of 6a517c6

It looks like this was also missed in 3.9 whatsnew https://docs.python.org/3/whatsnew/3.9.html#improved-modules

@ammaraskar ammaraskar added the needs backport to 3.9 only security fixes label Oct 29, 2020
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
nanjekyejoannah
nanjekyejoannah reviewed Jun 5, 2021
View reviewed changes
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an update to whatsnew @rhettinger ? Otherwise, this is okay to merge.

It's a small fix and we can merge without CLA, but the author is advised to sign the CLA for future contributions.

@nanjekyejoannah nanjekyejoannah mentioned this pull request Jun 7, 2021
Closed
@ambv ambv added the needs backport to 3.10 only security fixes label Jul 12, 2021
@ambv ambv merged commit da2e673 into python:main Jul 12, 2021
@miss-islington
Copy link
Contributor

Thanks @shangxiao for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 12, 2021
@shangxiao @miss-islington
bpo-42194: Add "New in version: 3.9" to argparse.BooleanOptionalAction (
5aee7d2 
pythonGH-23026)

(cherry picked from commit da2e673)

Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
@bedevere-bot
Copy link

GH-27097 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 12, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 12, 2021
@shangxiao @miss-islington
bpo-42194: Add "New in version: 3.9" to argparse.BooleanOptionalAction (
ac7cc7d 
pythonGH-23026)

(cherry picked from commit da2e673)

Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
ambv pushed a commit that referenced this pull request Jul 12, 2021
@miss-islington @shangxiao
bpo-42194: Add "New in version: 3.9" to argparse.BooleanOptionalAction (
721d479 
GH-23026) (#27097)

(cherry picked from commit da2e673)

Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
@ambv ambv added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Jul 12, 2021
@miss-islington
Copy link
Contributor

Thanks @shangxiao for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

ambv pushed a commit that referenced this pull request Jul 12, 2021
@miss-islington @shangxiao
bpo-42194: Add "New in version: 3.9" to argparse.BooleanOptionalAction (
c786988 
GH-23026) (#27098)

(cherry picked from commit da2e673)

Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
@ambv ambv removed the needs backport to 3.9 only security fixes label Jul 12, 2021
@ambv
Copy link
Contributor

ambv commented Jul 12, 2021

3.9 backport was #27098

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah left review comments

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shangxiao @the-knights-who-say-ni @ammaraskar @miss-islington @bedevere-bot @ambv @nanjekyejoannah