bpo-42212: check if generated files are up-to-date in github actions #23042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29c3870 to
4a8d1ef
Compare
Network issue. I re-run the job. |
vstinner
reviewed
Oct 31, 2020
vstinner
reviewed
Oct 31, 2020
https: //github.com/python/core-workflow/issues/380 Signed-off-by: Filipe Laíns <lains@archlinux.org>
vstinner
reviewed
Nov 20, 2020
| exit 1 | ||
| fi | ||
| - name: Check exported libpython symbols | ||
| run: make smelly |
There was a problem hiding this comment.
I wanted to suggest to add a message explaining that the check ensures that libpython only exports starting with Py and _Py. But instead, I wrote PR #23423 to enhance the script directly ;-)
|
Merged, thanks! |
|
GH-23493 is a backport of this pull request to the 3.8 branch. |
|
GH-23494 is a backport of this pull request to the 3.9 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python/core-workflow#380
https://bugs.python.org/issue42212