Skip to content

bpo-38119: fix shared memory's resource tracking #23174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bpo-38119: fix shared memory's resource tracking #23174

wants to merge 1 commit into from

Conversation

vinay0410
Copy link
Contributor

@vinay0410 vinay0410 commented Nov 6, 2020 •
edited
Loading

  • Update tests
  • Update documentation (if necessary)

https://bugs.python.org/issue38119

@vinay0410 vinay0410 requested a review from tiran as a code owner November 6, 2020 07:45
@vinay0410 vinay0410 mentioned this pull request Nov 6, 2020
Closed
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@tiran tiran removed their request for review April 17, 2021 21:15
MaxwellDupre
MaxwellDupre suggested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there are auto tests which fail, including my own test:
./python Lib/test/test_multiprocessing_main_handling.py
Ran 39 tests in 11.392s
FAILED (failures=26)
cpython on  fix-issue-38119 [$?] via 🐍 v3.11.0a5+ took 11s
Can you check and fix?

@applio applio mentioned this pull request Apr 11, 2022
Open
3 tasks
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 31, 2022
iritkatriel
iritkatriel requested changes Nov 27, 2022
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@ambv
Copy link
Contributor

ambv commented Dec 3, 2022

This is an impressive PR but I think the solution here is wrong. See #82300 (comment).

@ambv
Copy link
Contributor

ambv commented May 19, 2023

We're going with a simpler solution per the comment on the issue.

@ambv ambv closed this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel requested changes

@MaxwellDupre MaxwellDupre MaxwellDupre requested changes

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vinay0410 @bedevere-bot @ambv @iritkatriel @MaxwellDupre @the-knights-who-say-ni @ezio-melotti