-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
bpo-42131: Add PEP 451-related methods to zipimport #23187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can find_loader
and load_module
be expressed in terms of find_spec
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I'm also curious as to whether or not the old methods could be redefined in terms of the new one.
Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
@serhiy-storchaka @ncoghlan the reason I didn't port the old methods over is I'm planning to deprecate them (and all other instances of |
Specifically, find_spec(), create_module(), and exec_module(). Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
https://bugs.python.org/issue42131