Skip to content

Clarify that Set._from_iterable is not required to be a classmethod. #23272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 21, 2020
Merged

Clarify that Set._from_iterable is not required to be a classmethod. #23272

merged 4 commits into from
Nov 21, 2020

Conversation

rickeylev
Copy link
Contributor

In the implementation, _from_iterable is only used via self, and
requiring _from_iterable to be a classmethod makes it of little
value to subclasses with different constructor signatures.

@rickeylev
Clarify that Set._from_iterable is not required to be a classmethod.
f18162b 
In the implementation, `_from_iterable` is only used via `self`, and
requiring `_from_iterable` to be a classmethod makes it of little
value to subclasses with different constructor signatures.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@rickeylev

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 13, 2020
rhettinger
rhettinger requested changes Nov 15, 2020
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@rickeylev
Address review feedback.
f1057d4 
* Restore mention default impl is class doc
* Rephrase to say impl can be class or regular method
* Add tests to verify instance method _from_iterable works
@rickeylev
Remove/fix some extra/extraneous whitespace
0a37330
@rickeylev
Remove extraneous "method" word
97b9ddf
@rickeylev
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

@rhettinger rhettinger merged commit 68f68fa into python:master Nov 21, 2020
@miss-islington
Copy link
Contributor

Thanks @rickeylev for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-23450 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 21, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2020
@rickeylev @miss-islington
Clarify that Set._from_iterable is not required to be a classmethod. (p…
467b635 
…ythonGH-23272)

(cherry picked from commit 68f68fa)

Co-authored-by: Richard Levasseur <richardlev@gmail.com>
rhettinger pushed a commit that referenced this pull request Nov 21, 2020
@miss-islington
Clarify that Set._from_iterable is not required to be a classmethod. (G…
89d74d0 
…H-23272) (GH-23450)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@rickeylev @adorilson
Clarify that Set._from_iterable is not required to be a classmethod. (p…
aead64a 
…ythonGH-23272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickeylev @the-knights-who-say-ni @bedevere-bot @miss-islington @rhettinger