Skip to content

bpo-42120: Remove macro defining copysign to _copysign on Windows #23326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2020
Merged

bpo-42120: Remove macro defining copysign to _copysign on Windows #23326

merged 1 commit into from
Nov 16, 2020

Conversation

zooba
Copy link
Member

@zooba zooba commented Nov 16, 2020 •
edited by bedevere-bot
Loading

@zooba zooba added type-bug An unexpected behavior, bug, or error OS-windows needs backport to 3.8 needs backport to 3.9 only security fixes labels Nov 16, 2020
@zooba zooba requested a review from a team as a code owner November 16, 2020 22:42
@zooba zooba merged commit 9cc9e27 into python:master Nov 16, 2020
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @zooba, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 9cc9e277254023c0ca08e1a9e379fd89475ca9c2 3.9

@zooba zooba deleted the bpo-42120 branch November 16, 2020 23:22
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2020
@zooba @miss-islington
bpo-42120: Remove macro defining copysign to _copysign on Windows (py…
75b18b4 
…thonGH-23326)

(cherry picked from commit 9cc9e27)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

GH-23330 is a backport of this pull request to the 3.8 branch.

@zooba zooba added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Nov 16, 2020
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-23331 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 16, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2020
@zooba @miss-islington
bpo-42120: Remove macro defining copysign to _copysign on Windows (py…
5b994a2 
…thonGH-23326)

(cherry picked from commit 9cc9e27)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Nov 16, 2020
@miss-islington @zooba
bpo-42120: Remove macro defining copysign to _copysign on Windows (GH…
4f54ca0 
…-23326)

(cherry picked from commit 9cc9e27)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Nov 17, 2020
@miss-islington @zooba
[3.9] bpo-42120: Remove macro defining copysign to _copysign on Windo…
2c38e49 
…ws (GH-23326) (GH-23331)

(cherry picked from commit 9cc9e27)


Co-authored-by: Steve Dower <steve.dower@python.org>
This was referenced Dec 30, 2020
Closed
Closed
@mihaimaruseac mihaimaruseac mentioned this pull request Feb 17, 2021
Closed
@ahtik ahtik mentioned this pull request Feb 22, 2021
Closed
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@zooba @adorilson
bpo-42120: Remove macro defining copysign to _copysign on Windows (py…
a8c7596 
…thonGH-23326)
@jjerphan jjerphan mentioned this pull request Dec 5, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zooba zooba

Labels
OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zooba @miss-islington @bedevere-bot @the-knights-who-say-ni