Skip to content

Add GCC pragmas to silence compiler warning about ffi_prep_closure #23327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2020
Merged

Add GCC pragmas to silence compiler warning about ffi_prep_closure #23327

merged 1 commit into from
Nov 16, 2020

Conversation

pablogsal
Copy link
Member

This silences this warning also for GCC and clang on Linux:

~/github/python/master master* 1m 20s
❯ make -j -s
 CC='gcc -pthread' LDSHARED='gcc -pthread -shared    ' OPT='-g -Og -Wall'       _TCLTK_INCLUDES='' _TCLTK_LIBS=''       ./python -E ./setup.py -q build
/home/pablogsal/github/python/master/Modules/_ctypes/callbacks.c: In function ‘_ctypes_alloc_callback’:
/home/pablogsal/github/python/master/Modules/_ctypes/callbacks.c:437:9: warning: ‘ffi_prep_closure’ is deprecated: use ffi_prep_closure_loc instead [-Wdeprecated-declarations]
  437 |         result = ffi_prep_closure(p->pcl_write, &p->cif, closure_fcn, p);
      |         ^~~~~~
In file included from /home/pablogsal/github/python/master/Modules/_ctypes/callbacks.c:6:
/usr/include/ffi.h:334:1: note: declared here
  334 | ffi_prep_closure (ffi_closure*,
      | ^~~~~~~~~~~~~~~~

The following modules found by detect_modules() in setup.py, have been
built by the Makefile instead, as configured by the Setup files:
_abc                  atexit                pwd
time

@pablogsal pablogsal merged commit cce3f0b into python:master Nov 16, 2020
@serhiy-storchaka
Copy link
Member

Maybe backport it? Warnings in 3.9 annoy me.

@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 1, 2020
@pablogsal @miss-islington
Add GCC pragmas to silence compiler warning about ffi_prep_closure (p…
9a98e15 
…ythonGH-23327)

(cherry picked from commit cce3f0b)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 1, 2020
@bedevere-bot
Copy link

GH-23590 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cce3f0b0c88eba98bc11abe703a444bee7880ff8 3.8

pablogsal added a commit that referenced this pull request Dec 1, 2020
@miss-islington @pablogsal
Add GCC pragmas to silence compiler warning about ffi_prep_closure (G…
ae48dd4 
…H-23327) (GH-23590)

(cherry picked from commit cce3f0b)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pablogsal @adorilson
Add GCC pragmas to silence compiler warning about ffi_prep_closure (p…
6d4fa8e 
…ythonGH-23327)
@pablogsal pablogsal deleted the ifdefs branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pablogsal pablogsal

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni