Skip to content

[3.9] bpo-40998: Fix a refleak in create_filter() (GH-23365) #23369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

[3.9] bpo-40998: Fix a refleak in create_filter() (GH-23365) #23369

merged 1 commit into from
Nov 18, 2020

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 18, 2020 •
edited by miss-islington
Loading

(cherry picked from commit d1e38d4)

https://bugs.python.org/issue40998

Automerge-Triggered-By: GH:tiran

@bedevere-bot bedevere-bot mentioned this pull request Nov 18, 2020
Merged
@tiran tiran force-pushed the backport-d1e38d4-3.9 branch from d1798a5 to ac7fa7c Compare November 18, 2020 15:09
vstinner
vstinner approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

note: Py_INCREF() is not well indented :-)

@tiran tiran force-pushed the backport-d1e38d4-3.9 branch from ac7fa7c to fa71a0f Compare November 18, 2020 16:19
@tiran
Copy link
Member Author

tiran commented Nov 18, 2020

note: Py_INCREF() is not well indented :-)

Ah, my editor inserted a tab. Fixed!

@miss-islington miss-islington merged commit 35bf8ea into python:3.9 Nov 18, 2020
@miss-islington
Copy link
Contributor

@vstinner: Status check is done, and it's a success ✅ .

@tiran tiran mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiran @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot