Skip to content

bpo-42260: Improve error handling in _PyConfig_FromDict #23488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2020
Merged

bpo-42260: Improve error handling in _PyConfig_FromDict #23488

merged 1 commit into from
Nov 24, 2020

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 24, 2020 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error skip news labels Nov 24, 2020
@serhiy-storchaka serhiy-storchaka mentioned this pull request Nov 24, 2020
Closed
vstinner
vstinner approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The test (Lib/test/_test_embed_set_config.py) passed, so I'm fine with these changes :-)

@serhiy-storchaka serhiy-storchaka merged commit 14d81dc into python:master Nov 24, 2020
@serhiy-storchaka serhiy-storchaka deleted the _PyConfig_FromDict-errors branch November 24, 2020 12:07
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@serhiy-storchaka @adorilson
bpo-42260: Improve error handling in _PyConfig_FromDict (pythonGH-23488)
c60f6f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @vstinner @the-knights-who-say-ni @bedevere-bot