bpo-42508: Keep IDLE running on macOS #23577
Conversation
Remove obsolete workaround that prevented running files with shortcuts when using new universal2 installers built on macOS 11.
There was a problem hiding this comment.
That does look rather suspicious! On 3.9.1rc1 with adding this PR and with GH-23571, the documented smoke test still gets two "syntax error' popups as before but when the syntax error is corrected and saved, the attempt to execute using F5 now appears to work correctly. A definite improvement!
|
I hand copied the code that worked on my Airbook installation, to ignore bogus 2nd run_module_event call, to my IDLE editor on Windows. .02 delay is enough on the 2012 Airbook. .05, to be safer, is likely less than any sanely possible delay between errorbox and actual human F5 keypress. I can manage .09 with two poised fingers. Much quicker and the modal box is not gone. (Reconsidering 'modal' is a different issue.) I presume you have the git-fu to extract the new commit and apply it to your experimental branch, as you did before. |
There was a problem hiding this comment.
I tested the revised PR again on 3.9.1rc1 with adding this PR and with GH-23571. The smoke test now appears to work correctly with 8.6.10 (on 11 Big Sur, 10.15.7 Catalina, and 10.9) and I verified that with those changes the smoke test continues to run as expected with 8.6.8 and the 10.9 installer variant on the same three OS levels. I did not attempt to test anything else. Good work!
|
With 3.10.0a3 and 3.9.1 final cutoffs imminent, I am going to merge this PR and a 3.9 backport so this fix makes those releases. |
|
Thanks @terryjreedy for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
|
GH-23669 is a backport of this pull request to the 3.9 branch. |
Remove obsolete workaround that prevented running files with shortcuts when using new universal2 installers built on macOS 11. Ignore buggy 2nd run_module_event call. (cherry picked from commit 57e5113) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-23670 is a backport of this pull request to the 3.8 branch. |
Remove obsolete workaround that prevented running files with shortcuts when using new universal2 installers built on macOS 11. Ignore buggy 2nd run_module_event call. (cherry picked from commit 57e5113) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Remove obsolete workaround that prevented running files with shortcuts when using new universal2 installers built on macOS 11. Ignore buggy 2nd run_module_event call. (cherry picked from commit 57e5113) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
Thank you. I have been doing some other stuff the last couple of days. I just tested many of the other shortcuts that work and found no problems. I will try to check again when something is released. |
Remove obsolete workaround that prevented running files with shortcuts when using new universal2 installers built on macOS 11. Ignore buggy 2nd run_module_event call. (cherry picked from commit 57e5113) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Remove obsolete workaround that prevented running files with shortcuts when using new universal2 installers built on macOS 11. Ignore buggy 2nd run_module_event call.
Remove obsolete workaround that prevented running files with
shortcuts when using new universal2 installers built on macOS 11.
https://bugs.python.org/issue42508