bpo-5054: CGIHTTPRequestHandler.run_cgi() HTTP_ACCEPT improperly parsed #23638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orsenthil: Please replace |
|
Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-23657 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2020
… parsed (pythonGH-23638) (cherry picked from commit da3d2ab) Co-authored-by: Senthil Kumaran <senthil@uthcode.com>
miss-islington
added a commit
that referenced
this pull request
Dec 5, 2020
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 15, 2021
…nviron on Windows (pythonGH-27161) pythonGH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test. (cherry picked from commit 82b218f) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 15, 2021
…nviron on Windows (pythonGH-27161) pythonGH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test. (cherry picked from commit 82b218f) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv
added a commit
that referenced
this pull request
Jul 15, 2021
…nviron on Windows (GH-27161) (#27169) GH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test. (cherry picked from commit 82b218f) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv
added a commit
that referenced
this pull request
Jul 15, 2021
…nviron on Windows (GH-27161) (#27170) GH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test. (cherry picked from commit 82b218f) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the special purpose getallmatchingheaders with generic get_all method and add relevant tests.
Original Patch by Martin Panter. Modified by Senthil Kumaran.
https://bugs.python.org/issue5054