Skip to content

bpo-41116: Fix setup.py test for macOS Tcl/Tk frameworks #23649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

ned-deily
Copy link
Member

@ned-deily ned-deily commented Dec 5, 2020

If no explicit macOS SDK was specified, setup.py should check for
Tcl and TK frameworks in /Library/Frameworks; the previous commit
inadvertently broke that test.

https://bugs.python.org/issue41116

If no explicit macOS SDK was specified, setup.py should check for
Tcl and TK frameworks in /Library/Frameworks; the previous commit
inadvertently broke that test.
@ned-deily ned-deily merged commit 29afab6 into python:master Dec 5, 2020
@miss-islington
Copy link
Contributor

Thanks @ned-deily for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@ned-deily ned-deily deleted the tcltk_fw_detect branch December 5, 2020 04:02
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2020
)

If no explicit macOS SDK was specified, setup.py should check for
Tcl and TK frameworks in /Library/Frameworks; the previous commit
inadvertently broke that test.
(cherry picked from commit 29afab6)

Co-authored-by: Ned Deily <nad@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 5, 2020
@bedevere-bot
Copy link

GH-23650 is a backport of this pull request to the 3.9 branch.

ned-deily added a commit that referenced this pull request Dec 5, 2020
) (GH-23650)

If no explicit macOS SDK was specified, setup.py should check for
Tcl and TK frameworks in /Library/Frameworks; the previous commit
inadvertently broke that test.
(cherry picked from commit 29afab6)

Co-authored-by: Ned Deily <nad@python.org>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
)

If no explicit macOS SDK was specified, setup.py should check for
Tcl and TK frameworks in /Library/Frameworks; the previous commit
inadvertently broke that test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants