-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-42584: Update macOS installer to use SQLite 3.34.0 #23674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @erlend-aasland for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Thanks @erlend-aasland for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Sorry, @erlend-aasland and @ned-deily, I could not cleanly backport this to |
Sorry @erlend-aasland and @ned-deily, I had trouble checking out the |
Thanks, @ned-deily! |
BTW, I'm (currently) unable to open PR's for 3.8 and 3.9 using the cherry-picker bco. GitHub connection issues. You may have better luck, @ned-deily. |
@erlend-aasland, are you able to use "git cherry-pick " from the command line? It's a useful skill for a maintainer :) What sort of problem are you having? |
I have no problem running the cherry-picker, thank you ;) As you see from the PR log, my backports reference this PR. However, if I try to create the PR's (from my fork to cpython), GH times out. At first I assumed it was a network issue, but I've been getting the same timeout error until today, so now I assume it's a permission error of some sort. I'll restore the branches and give it another shot. |
GH-24129 is a backport of this pull request to the 3.8 branch. |
GH-24130 is a backport of this pull request to the 3.9 branch. |
Looking good! Cherry-picking from the commit in the cpython master branch is the way to go rather than from your own branches. |
Indeed. I'll remember not to use the |
https://bugs.python.org/issue42584