bpo-29176: curses: use tmpfile() for getwin/putwin #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use C function tmpfile() for curses.getwin() and curses.putwin(), instead of mkstemp() using an hardcoded /tmp path. The tmpfile() chooses the directory for the temporary file and so is more portable (especially, it works on Android). Replace also IOError with OSError: since the PEP 3151, IOError is an alias to OSError.
serhiy-storchaka
approved these changes
Feb 22, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Apr 20, 2021
The 4th argument has been changed from immediate=True to pending=False a long time ago.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
May 27, 2021
The 4th argument has been changed from immediate=True to pending=False a long time ago. (cherry picked from commit 12b78b0)
ahgamut
pushed a commit
to ahgamut/cpython
that referenced
this pull request
Aug 25, 2021
The 4th argument has been changed from immediate=True to pending=False a long time ago. (cherry picked from commit 12b78b0)
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
If celery or redis is down, then we can't perform "sleep". Heroku's web dyno times out after 30 seconds. 😥
jaraco
added a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
…ersable-docs abc: avoid abbreviations in the Traversable documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use C function tmpfile() for curses.getwin() and curses.putwin(),
instead of mkstemp() using an hardcoded /tmp path. The tmpfile()
chooses the directory for the temporary file and so is more portable
(especially, it works on Android).
Replace also IOError with OSError: since the PEP 3151, IOError is an
alias to OSError.
http://bugs.python.org/issue29176