Skip to content

[3.9] bpo-42517: [Enum] do not convert private names into members (GH-23722) #23748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 14, 2020
Merged

[3.9] bpo-42517: [Enum] do not convert private names into members (GH-23722) #23748

merged 3 commits into from
Dec 14, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 13, 2020 •
edited by bedevere-bot
Loading

private names, such as _Color__hue and _Color__hue_ are now normal attributes, and do not become members nor raise exceptions
(cherry picked from commit 7cf0aad)

Co-authored-by: Ethan Furman ethan@stoneleaf.us

https://bugs.python.org/issue42517

@ethanfurman @miss-islington
bpo-42517: [Enum] do not convert private names into members (pythonGH…
2324bdc 
…-23722)

private names, such as `_Color__hue` and `_Color__hue_` are now normal attributes, and do not become members nor raise exceptions
(cherry picked from commit 7cf0aad)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@bedevere-bot bedevere-bot mentioned this pull request Dec 13, 2020
Merged
@miss-islington
Copy link
Contributor Author

@ethanfurman: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@ethanfurman: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@ethanfurman: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@ethanfurman: Status check is done, and it's a failure ❌ .

@ethanfurman ethanfurman merged commit aba12b6 into python:3.9 Dec 14, 2020
@miss-islington miss-islington deleted the backport-7cf0aad-3.9 branch December 14, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @ethanfurman @the-knights-who-say-ni @bedevere-bot