bpo-42749: Fix testing bignum if Tkinter is compiled with Tk 8.4 and dynamic linked with Tk >= 8.5 #23955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dynamic linked with Tk >= 8.5
87da1ea to
f334d42
Compare
vstinner
approved these changes
Dec 26, 2020
| # bignum was added in Tcl 8.5, but its support is able only since 8.5.8. | ||
| # Actually it is determined at compile time, so using get_tk_patchlevel() | ||
| # is not reliable. | ||
| # TODO: expose full static version. |
There was a problem hiding this comment.
I'm not sure that this TODO is useful. Is there a need for the full static version for this specific test?
There was a problem hiding this comment.
The test will still fail if build Tkinter with 8.5 older than 8.5.8 or with alpha or beta of 8.6. Very unlikely.
I am planning to add named tuples (like sys.version_info) for static and dynamic versions. It is a part of large project which adds structured version for all external libraries.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 27, 2020
…dynamic linked with Tk >= 8.5 (pythonGH-23955) (cherry picked from commit b02ad24) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-23961 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 27, 2020
…dynamic linked with Tk >= 8.5 (pythonGH-23955) (cherry picked from commit b02ad24) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-23962 is a backport of this pull request to the 3.8 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Dec 27, 2020
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…dynamic linked with Tk >= 8.5 (pythonGH-23955)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue42749