Skip to content

[3.9] bpo-42822: Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" #24092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2021
Merged

[3.9] bpo-42822: Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" #24092

merged 1 commit into from
Jan 4, 2021

Conversation

JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Jan 4, 2021 •
edited by bedevere-bot
Loading

@JulienPalard JulienPalard requested review from 1st1, asvetlov, ethanfurman and a team as code owners January 4, 2021 12:35
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Jan 4, 2021
@JulienPalard
Copy link
Member Author

Hum no, a full revert is not needed, only some bits has to be reverted, let me check this in details.

@JulienPalard
Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (…
b806721 
…GH-23658)"

This partially reverts commit
e89993c, which was removing
backslashes in documentations compiled with Sphinx < 3, used for
Python 3.8 and 3.9 docs.
@JulienPalard JulienPalard force-pushed the revert-23827-backport-dcc997c-3.9 branch from 946dfdd to b806721 Compare January 4, 2021 12:46
@JulienPalard
Copy link
Member Author

I kept only backslashes involved in strings, which looks to be the only one causing troubles.

@JulienPalard JulienPalard changed the title Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" bpo-42822: Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" Jan 4, 2021
@JulienPalard JulienPalard changed the title bpo-42822: Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" [3.9] bpo-42822: Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" Jan 4, 2021
andresdelfino
andresdelfino approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@andresdelfino andresdelfino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulienPalard JulienPalard merged commit e6d0107 into 3.9 Jan 4, 2021
@JulienPalard JulienPalard deleted the revert-23827-backport-dcc997c-3.9 branch January 4, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresdelfino andresdelfino andresdelfino approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@ethanfurman ethanfurman Awaiting requested review from ethanfurman

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JulienPalard @andresdelfino @the-knights-who-say-ni @bedevere-bot