bpo-43176: Fix processing of empty dataclasses #24484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Please add an issue at bugs.python.org, and reference it here. See https://devguide.python.org/pullrequest/#quick-guide |
|
I created a bug and referenced it here, thanks for the link to the guide! (this is my first PR in cpython) Test failures do not seem to be related to the added changes (test_ssl and test_asyncio failed). Please let me know if I'm wrong. |
|
This PR is stale because it has been open for 30 days with no activity. |
|
Thanks @hbq1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 6, 2021
When a dataclass inherits from an empty base, all immutability checks are omitted. This PR fixes this and adds tests for it. Automerge-Triggered-By: GH:ericvsmith (cherry picked from commit 376ffc6) Co-authored-by: Iurii Kemaev <6885137+hbq1@users.noreply.github.com>
|
GH-25205 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 6, 2021
When a dataclass inherits from an empty base, all immutability checks are omitted. This PR fixes this and adds tests for it. Automerge-Triggered-By: GH:ericvsmith (cherry picked from commit 376ffc6) Co-authored-by: Iurii Kemaev <6885137+hbq1@users.noreply.github.com>
|
GH-25206 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Apr 6, 2021
When a dataclass inherits from an empty base, all immutability checks are omitted. This PR fixes this and adds tests for it. Automerge-Triggered-By: GH:ericvsmith (cherry picked from commit 376ffc6) Co-authored-by: Iurii Kemaev <6885137+hbq1@users.noreply.github.com>
|
ericvsmith
pushed a commit
that referenced
this pull request
Apr 6, 2021
When a dataclass inherits from an empty base, all immutability checks are omitted. This PR fixes this and adds tests for it. Automerge-Triggered-By: GH:ericvsmith (cherry picked from commit 376ffc6) Co-authored-by: Iurii Kemaev <6885137+hbq1@users.noreply.github.com> Co-authored-by: Iurii Kemaev <6885137+hbq1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dataclass inherits from an empty base, all immutability checks are omitted. This PR fixes this and adds tests for it.
https://bugs.python.org/issue43176
Automerge-Triggered-By: GH:ericvsmith