Skip to content

bpo-42967: Fix urllib.parse docs and make logic clearer #24536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2021
Merged

bpo-42967: Fix urllib.parse docs and make logic clearer #24536

merged 2 commits into from
Feb 15, 2021

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Feb 15, 2021 •
edited
Loading

In PR #24528, I noticed some doc errors and code clarity nits I failed to catch introduced by fcbe0cb.

Doc errors fixed:

  1. Using default role in rST for styling code (ie not using double backticks for code).
  2. Line character count over 80 (I only applied this formatting if the line had error number 1 too, lines with only this problem were left untouched to reduce git blame confusion.)

Code clarity:
isinstance accepts a tuple.

https://bugs.python.org/issue42967

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 15, 2021
@Fidget-Spinner
Copy link
Member Author

I think we can skip news because it shares the same news as the other PR.
cc: @AdamGold, @orsenthil

@Fidget-Spinner Fidget-Spinner changed the title bpo-42967: Fix docs on main branch bpo-42967: Fix whatsnew and urllib.parse docs on main branch Feb 15, 2021
@Fidget-Spinner Fidget-Spinner mentioned this pull request Feb 15, 2021
Merged
@Fidget-Spinner Fidget-Spinner marked this pull request as draft February 15, 2021 16:11
@Fidget-Spinner Fidget-Spinner marked this pull request as ready for review February 15, 2021 16:15
@Fidget-Spinner Fidget-Spinner changed the title bpo-42967: Fix whatsnew and urllib.parse docs on main branch bpo-42967: Fix urllib.parse docs and make logic clearer Feb 15, 2021
orsenthil
orsenthil approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented Feb 15, 2021 •
edited
Loading

@orsenthil CI tests are green other than bedevere which needs a skip news label (I can't apply labels, sorry).

Edit:
woops sorry waiting for macOS

@orsenthil orsenthil merged commit a2f0654 into python:master Feb 15, 2021
@Fidget-Spinner Fidget-Spinner deleted the fixdocs-fcbe0cb branch February 15, 2021 17:03
sthagen added a commit to sthagen/python-cpython that referenced this pull request Feb 15, 2021
@sthagen
Merge pull request #389 from python/master
9107190 
bpo-42967: Fix urllib.parse docs and make logic clearer (pythonGH-24536)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@Fidget-Spinner @adorilson
bpo-42967: Fix urllib.parse docs and make logic clearer (pythonGH-24536)
8041fc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil orsenthil approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fidget-Spinner @orsenthil @the-knights-who-say-ni @bedevere-bot