Skip to content

Fix somewhat confusing "where" strings in Py_EnterRecursiveCall #24764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

congma
Copy link

@congma congma commented Mar 5, 2021

  • In object.c: in PyObject_RichCompare(), change " in comparison" to
    more descriptive text.
  • In _ctypes.c: in PyCSimpleType_from_param(), add missing initial
    space.

Not bugs per se but these strings cause somewhat annoying traceback messages with RecursionError. For example, the one in PyObject_RichCompare() manifests as

RecursionError: maximum recursion depth exceeded in comparison

The syntax is a bit weird ("in comparison with what?"), and it doesn't help identifying the location of the call.

- In object.c: in PyObject_RichCompare(), change " in comparison" to
  more descriptive text.
- In _ctypes.c: in PyCSimpleType_from_param(), add missing initial
  space.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@congma

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 11, 2021
@iritkatriel
Copy link
Member

please create an issue on bugs.python.org (b.p.o) describing the proposed change.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 5, 2022
@bedevere-app

This comment was marked as resolved.

@serhiy-storchaka
Copy link
Member

The change in _ctypes.c is trivial and does not need opening an issue.

The change in object.c is less trivial to me, but it can be trivial to native English speakers. If any other core developer approves it, it will not not need opening an issue.

In any case, your sign of the CLI is required, @congma. Even if you already signed it on bugs.python.org, please sign it again. We cannot merge any changes without this.

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

The following commit authors need to sign the Contributor License Agreement:

CLA signed

@python python deleted a comment Apr 7, 2025
@hugovk hugovk changed the title bpo-None: Fix somewhat confusing "where" strings in Py_EnterRecursiveCall. Fix somewhat confusing "where" strings in Py_EnterRecursiveCall. Apr 7, 2025
@hugovk hugovk changed the title Fix somewhat confusing "where" strings in Py_EnterRecursiveCall. Fix somewhat confusing "where" strings in Py_EnterRecursiveCall Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants