-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
Fix somewhat confusing "where" strings in Py_EnterRecursiveCall #24764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix somewhat confusing "where" strings in Py_EnterRecursiveCall #24764
Conversation
- In object.c: in PyObject_RichCompare(), change " in comparison" to more descriptive text. - In _ctypes.c: in PyCSimpleType_from_param(), add missing initial space.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
This PR is stale because it has been open for 30 days with no activity. |
please create an issue on bugs.python.org (b.p.o) describing the proposed change. |
This comment was marked as resolved.
This comment was marked as resolved.
The change in The change in In any case, your sign of the CLI is required, @congma. Even if you already signed it on bugs.python.org, please sign it again. We cannot merge any changes without this. |
The following commit authors need to sign the Contributor License Agreement: |
more descriptive text.
space.
Not bugs per se but these strings cause somewhat annoying traceback messages with
RecursionError
. For example, the one inPyObject_RichCompare()
manifests asThe syntax is a bit weird ("in comparison with what?"), and it doesn't help identifying the location of the call.