bpo-43659: check for curses.update_lines_cols() in Lib/test/test_curses.py #25074

aixtools · 2021-03-29T18:03:00Z

AIX libcurses.a does not provide support for curses.update_lines_cols(). This patch permits the test_curses
to skip a test that requires curses.update_lines_cols() support.
Backport to Python3.8 and/or Python3.9 also needed.
Further, a NEWS blurb is not included. One can be added if deemed necessary.

https://bugs.python.org/issue43659

support for `curses.update_lines_cols()`. This patch permits the test_curses to skip a test that requires `curses.update_lines_cols()` support.

miss-islington · 2021-03-29T19:06:48Z

Thanks @aixtools for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington · 2021-03-29T19:06:48Z

Thanks @aixtools for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

curses.update_lines_cols() is only defined when the curses library provides either resizeterm() or resize_term() functions which are optional and are not provided on AIX. (cherry picked from commit c8b5738) Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>

bedevere-bot · 2021-03-29T19:07:08Z

GH-25076 is a backport of this pull request to the 3.9 branch.

curses.update_lines_cols() is only defined when the curses library provides either resizeterm() or resize_term() functions which are optional and are not provided on AIX. (cherry picked from commit c8b5738) Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>

bedevere-bot · 2021-03-29T19:07:15Z

GH-25077 is a backport of this pull request to the 3.8 branch.

curses.update_lines_cols() is only defined when the curses library provides either resizeterm() or resize_term() functions which are optional and are not provided on AIX. (cherry picked from commit c8b5738) Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>

bedevere-bot · 2021-03-29T19:32:33Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL7 LTO + PGO 3.x has failed when building commit c8b5738.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/96/builds/914) and take a look at the build logs.
Check if the failure is related to this commit (c8b5738) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/96/builds/914

Failed tests:

test_tools

Failed subtests:

test_reindent_file_with_bad_encoding - test.test_tools.test_reindent.ReindentTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

412 tests OK.

10 slowest tests:

test_mailbox: 4 min 53 sec
test_shelve: 4 min 37 sec
test_concurrent_futures: 2 min 46 sec
test_multiprocessing_spawn: 1 min 42 sec
test_tokenize: 1 min 42 sec
test_unparse: 1 min 39 sec
test_lib2to3: 1 min 28 sec
test_asyncio: 1 min 28 sec
test_io: 1 min 10 sec
test_multiprocessing_forkserver: 1 min 5 sec

1 test failed:
test_tools

14 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_tools

Total duration: 8 min 43 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/test/test_tools/test_reindent.py", line 29, in test_reindent_file_with_bad_encoding
    rc, out, err = assert_python_ok(self.script, '-r', bad_coding_path)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/test/support/script_helper.py", line 160, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/test/support/script_helper.py", line 145, in _assert_python
    res.fail(cmd_line)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/test/support/script_helper.py", line 72, in fail
    raise AssertionError("Process return code is %d\n"
AssertionError: Process return code is 1
command line: ['/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/python', '-X', 'faulthandler', '-I', '/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Tools/scripts/reindent.py', '-r', '/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/test/bad_coding.py']

bedevere-bot · 2021-03-29T19:41:09Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL7 LTO 3.x has failed when building commit c8b5738.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/507/builds/900) and take a look at the build logs.
Check if the failure is related to this commit (c8b5738) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/507/builds/900

Failed tests:

test_tools

Failed subtests:

test_reindent_file_with_bad_encoding - test.test_tools.test_reindent.ReindentTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

412 tests OK.

10 slowest tests:

test_shelve: 4 min 25 sec
test_peg_generator: 3 min 35 sec
test_concurrent_futures: 2 min 51 sec
test_multiprocessing_spawn: 1 min 41 sec
test_tokenize: 1 min 40 sec
test_asyncio: 1 min 27 sec
test_unparse: 1 min 26 sec
test_lib2to3: 1 min 24 sec
test_mailbox: 1 min 18 sec
test_multiprocessing_forkserver: 1 min 8 sec

1 test failed:
test_tools

14 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_tools

Total duration: 6 min 35 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_tools/test_reindent.py", line 29, in test_reindent_file_with_bad_encoding
    rc, out, err = assert_python_ok(self.script, '-r', bad_coding_path)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/support/script_helper.py", line 160, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/support/script_helper.py", line 145, in _assert_python
    res.fail(cmd_line)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/support/script_helper.py", line 72, in fail
    raise AssertionError("Process return code is %d\n"
AssertionError: Process return code is 1
command line: ['/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/python', '-X', 'faulthandler', '-I', '/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Tools/scripts/reindent.py', '-r', '/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/bad_coding.py']

AIX: the default libcurses.a provided by base AIX does not include

b687f53

support for `curses.update_lines_cols()`. This patch permits the test_curses to skip a test that requires `curses.update_lines_cols()` support.

the-knights-who-say-ni added the CLA signed label Mar 29, 2021

bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Mar 29, 2021

serhiy-storchaka approved these changes Mar 29, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Mar 29, 2021

serhiy-storchaka added the skip news label Mar 29, 2021

serhiy-storchaka merged commit c8b5738 into python:master Mar 29, 2021

bedevere-bot removed the awaiting merge label Mar 29, 2021

serhiy-storchaka added needs backport to 3.8 needs backport to 3.9 only security fixes labels Mar 29, 2021

bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 29, 2021

bedevere-bot removed the needs backport to 3.8 label Mar 29, 2021

aixtools mentioned this pull request Apr 10, 2022

AIX: test_curses crashes buildbot #87825

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bpo-43659: check for curses.update_lines_cols() in Lib/test/test_curses.py #25074

bpo-43659: check for curses.update_lines_cols() in Lib/test/test_curses.py #25074

Uh oh!

aixtools commented Mar 29, 2021 •

edited

Loading

Uh oh!

miss-islington commented Mar 29, 2021

Uh oh!

miss-islington commented Mar 29, 2021

Uh oh!

bedevere-bot commented Mar 29, 2021

Uh oh!

bedevere-bot commented Mar 29, 2021

Uh oh!

bedevere-bot commented Mar 29, 2021

Uh oh!

bedevere-bot commented Mar 29, 2021

Uh oh!

Uh oh!

Uh oh!

bpo-43659: check for curses.update_lines_cols() in Lib/test/test_curses.py #25074

bpo-43659: check for curses.update_lines_cols() in Lib/test/test_curses.py #25074

Uh oh!

Conversation

aixtools commented Mar 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented Mar 29, 2021

Uh oh!

miss-islington commented Mar 29, 2021

Uh oh!

bedevere-bot commented Mar 29, 2021

Uh oh!

bedevere-bot commented Mar 29, 2021

Uh oh!

bedevere-bot commented Mar 29, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Mar 29, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!

aixtools commented Mar 29, 2021 •

edited

Loading