bpo-43756: Add new audit event to incorporate new arguments added to glob.glob #25239
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
reviewed
Apr 7, 2021
Doc/library/glob.rst
Outdated
| @@ -65,6 +65,7 @@ For example, ``'[?]'`` matches the character ``'?'``. | |||
| match. | |||
|
|
|||
| .. audit-event:: glob.glob pathname,recursive glob.glob | |||
| .. audit-event:: glob.glob/2 pathname,root_dir,dir_fd,recursive glob.glob | |||
There was a problem hiding this comment.
I don't see any particular reason to insert the new parameters compared to the previous event - why not keep the first two the same and just add the new ones on the end?
There was a problem hiding this comment.
I was just matching the order as presented in the function signature documentation. I've revised the PR to append new parameters at the end.
zooba
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new audit event
glob.glob/2to incorporate the newroot_diranddir_fdarguments added toglob.globandglob.iglobin Python 3.10.https://bugs.python.org/issue43756