-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-43762: Add audit events for loading of sqlite3 extensions #25246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc. @tiran |
fcbf3a3
to
36f075f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor tweaks, mainly for readability/ease of use.
I wonder if it's worth returning the connection object when it's created (through a new event in module.c) and then reference it in these events? That can then correlate these (and other) events with the file - we do this already for sockets.
After some thought, I think it's probably not worth it for these ones. The important information is in the extension being loaded, and it doesn't really relate to the connection at all. However, if we wanted to add it later, we couldn't. So might be worth doing now?
20dda83
to
ea0116c
Compare
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
ea0116c
to
dd2ffde
Compare
FYI, rebased onto |
…r post connect events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with the doc update suggestions
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Thanks for reviewing! BTW, I used |
https://bugs.python.org/issue43762