-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-43894: Editor reformat #25485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-43894: Editor reformat #25485
Conversation
I presume this doesn't need a news entry, but I am happy to added one if necessary. |
Following the changes proposed in #25479, I would like a little more time on this PR before review (no point commenting on exactly the same things). |
c3ab35d
to
b0eb61e
Compare
OK, say when done. |
@terryjreedy I think this is ready now. I would appreciate your particular scrutiny of where I have added an explicit check for |
Can you describe the 'issues'? Could you have uncovered a bug? Or are you really convinced that your initial thought was wrong? |
Sorry, just things like passing a blank string to tkinter and so getting an error. This was a regression with my change (a blank string would be treated as false but my |
Given that it is highly unlikely this is going to be merged (at least in the current form), I am closing this PR. I will leave the issue on bpo open for now. |
Yes, leave issue open. My quick review is that I eventually want most but not all of the changes. (In particular, "Return xyz." is a legal docstring.) Some of the changes I would like one type at a time. There is an existing issue with more tests that is probably about ready to merge once I review it. But working on shell indents and sidebar now. So wait until I ask for something in particular. |
https://bugs.python.org/issue43894