bpo-37322: Fix ResourceWarning and exception handling in test (GH-25553) #25553
Conversation
|
🤖 New build scheduled with the buildbot fleet by @tiran for commit a3594aab883ba2e1d47ab853c1301d68c66fe2e3 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
Buildbots failed to trigger, let's try again. |
|
🤖 New build scheduled with the buildbot fleet by @tiran for commit a3594aab883ba2e1d47ab853c1301d68c66fe2e3 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit a3594aab883ba2e1d47ab853c1301d68c66fe2e3 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
| # On Windows sometimes test_pha_required_nocert receives the | ||
| # PEER_DID_NOT_RETURN_A_CERTIFICATE exception | ||
| # before the 'tlsv13 alert certificate required' exception. | ||
| # If the server is stopped when PEER_DID_NOT_RETURN_A_CERTIFICATE | ||
| # is received test_pha_required_nocert fails with ConnectionResetError | ||
| # because the underlying socket is closed |
There was a problem hiding this comment.
Is there a risk of this failing on Windows, or would this be covered by the CI suite? I'm not too familiar with the code (nor windows) so I kept away from this when I was looking around this issue.
There was a problem hiding this comment.
Python has pre-commit CI and post-commit buildbots for all major platforms including multiple flavors of Windows.
It doesn't make any sense the raise an exception here. The exception just breaks the handler thread and does not even end up in the test case.
There was a problem hiding this comment.
Thanks! That clears things up
a3594aa to
04260c4
Compare
|
🤖 New build scheduled with the buildbot fleet by @tiran for commit 04260c43c5879a7ef3800c045d9dfacab5c225a1 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
🤖 New build scheduled with the buildbot fleet by @tiran for commit 62653f2715fc4e8f9c991b867cee5825fc4d0077 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
62653f2 to
b0b4024
Compare
b0b4024 to
25fd780
Compare
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
|
Sorry, @tiran, I could not cleanly backport this to |
|
Sorry @tiran, I had trouble checking out the |
|
GH-25572 is a backport of this pull request to the 3.9 branch. |
|
GH-25573 is a backport of this pull request to the 3.8 branch. |
…ythonGH-25553) Revert 73ea546, increase logging, and improve stability of test. Handle all OSErrors in a single block. OSError also takes care of SSLError and socket's connection errors. Partly reverts commit fb7e750. The threaded connection handler must not raise an unhandled exception.. (cherry picked from commit c8666cf) Co-authored-by: Christian Heimes <christian@python.org>
…ythonGH-25553) Revert 73ea546, increase logging, and improve stability of test. Handle all OSErrors in a single block. OSError also takes care of SSLError and socket's connection errors. Partly reverts commit fb7e750. The threaded connection handler must not raise an unhandled exception.. (cherry picked from commit c8666cf) Co-authored-by: Christian Heimes <christian@python.org>
Handle all OSErrors in a single block. OSError also takes care of
SSLError and socket's connection errors.
Partly reverts commit fb7e750. The
threaded connection handler must not raise an unhandled exception.
https://bugs.python.org/issue37322