[3.9] bpo-37322: Fix ResourceWarning and exception handling in test (GH-25553) #25572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
997d9c4 to
17fd03d
Compare
…ythonGH-25553) Revert 73ea546, increase logging, and improve stability of test. Handle all OSErrors in a single block. OSError also takes care of SSLError and socket's connection errors. Partly reverts commit fb7e750. The threaded connection handler must not raise an unhandled exception.. (cherry picked from commit c8666cf) Co-authored-by: Christian Heimes <christian@python.org>
17fd03d to
5d1fb45
Compare
…25561) test_wrong_cert_tls13 sometimes fails on some Windows buildbots. Turn failing test case into skipped test case until we have more time to investigate. Signed-off-by: Christian Heimes <christian@python.org>
|
There's a few hours left for this to get fixed for inclusion in 3.9.5. |
|
The PR is still unstable. I was not able to figure out the issue over the weekend and I won't have time in the next couple of hours to debug the problem. Let's try it again for 3.9.6. |
|
This PR is stale because it has been open for 30 days with no activity. |
|
https://bugs.python.org/issue37322 is closed. What is the status of this PR? |
|
We're releasing the last bugfix release of 3.9 today and this PR's been stale for a while. Sadly it's a wontfix now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert 73ea546, increase logging, and improve stability of test.
Handle all OSErrors in a single block. OSError also takes care of
SSLError and socket's connection errors.
Partly reverts commit fb7e750. The
threaded connection handler must not raise an unhandled exception..
(cherry picked from commit c8666cf)
Co-authored-by: Christian Heimes christian@python.org
https://bugs.python.org/issue37322